-
Notifications
You must be signed in to change notification settings - Fork 14
Fix to PhotoThermalWaveguides notebook for some numpy versions #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
momchil-flex
wants to merge
25
commits into
pre/2.10
Choose a base branch
from
momchil/photo_thermal_fix
base: pre/2.10
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: marcorudolphflex <marco.rudolph@flexcompute.com>
…mpedance api changed ThroughSiliconVia to disable port absorption while bug investigated turned off low frequency extrapolation feature for CPWRFPhotonics2
…ferences - Remove experimental feature notes from autograd notebooks - Update AutogradPlugin URLs to Autograd URLs - Replace 'adjoint plugin' text with 'autograd' or 'adjoint method' - Remove version 2.7 references - Clean up stale entries in import_file_mapping.json Resolves FXC-4452
Contributor
|
@alec-flexcompute can provide more comments? |
Contributor
|
Thanks for the feedback @momchil-flex ! Indeed, this example was developed partially as a way to test/familiarize myself with flexAgent. I agree it can just be removed, including the isotropic check. I'll make the corresponding edits shortly |
Contributor
|
Added the changes. I reran locally on my side as a sanity check and the results were the same |
alec-flexcompute
approved these changes
Dec 15, 2025
87aca99 to
a47d17c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice example btw! :)
One of the checks was erroring for me, which is what this PR fixes (maybe numpy v2 vs. v1 issue? not sure at which point this has become a hard error).
More generally, was this AI generated?
AI likes to do all these defensive checks. Normally, we don't really do this in our notebooks, and it would be quite verbose to do so everywhere. I feel like it can just be removed?
Regarding the isotropic permittivity check though (which is what I'm fixing), I feel like there's even a potential issue: why do we need the permittivity to be isotropic? Note that it won't be at geometry interfaces due to subpixel, which I assume is not a problem here if the recorded data does not cover the waveguide interface? But in general why enforce this at all as opposed to compute absorption components from each of the field/permittivity components separately, and add them up?